fix ErrorOnlyArchiver logging Error, also when there is none

first write Error file then Move File, so the move error can also be detected while the error writing is always done first
2024-10-26 19:13:32 +02:00 · 2024-09-27 16:59:38 +02:00
2 changed files with 7 additions and 2 deletions
--- a/ErrorOnlyArchiver.go
+++ b/ErrorOnlyArchiver.go
@ -9,10 +9,12 @@ func NewErrorOnlyArchiver(conf *Config) func(string, error) {
 	return func(filePath string, archiveErr error) {
 		if archiveErr != nil {
 			err := writeErrorFile(conf, filePath, archiveErr)
+			if err != nil {
 				logger.Error(err)
 			}
 		}
 	}
+}

 func writeErrorFile(conf *Config, filePath string, archiveErr error) error {
 	if archiveErr != nil {
--- a/FileArchiver.go
+++ b/FileArchiver.go
@ -94,10 +94,13 @@ func moveToError(conf *Config, filePath string, archiveErr error) error {
 	if err != nil {
 		return err
 	}
-	err = os.Rename(filePath, filepath.Join(destFolder, baseName))
 	err = writeErrorFile(conf, filePath, archiveErr)
 	if err != nil {
 		return err
 	}
+	err = os.Rename(filePath, filepath.Join(destFolder, baseName))
+	if err != nil {
+		return err
+	}
 	return nil
 }
Author	SHA1	Message	Date
Christian Schmied	76c2a7be5e	fix ErrorOnlyArchiver logging Error, also when there is none All checks were successful go/archiver/pipeline/head This commit looks good Details	2024-10-26 19:13:32 +02:00
Christian Schmied	1449729882	first write Error file then Move File, so the move error can also be detected while the error writing is always done first All checks were successful go/archiver/pipeline/head This commit looks good Details	2024-09-27 16:59:38 +02:00